Skip to content

[dependencies]: Fix lock file + change Ngx to type module#945

Merged
RiinaKuu merged 2 commits into
mainfrom
DS-663-fix-lock-file
Jun 18, 2026
Merged

[dependencies]: Fix lock file + change Ngx to type module#945
RiinaKuu merged 2 commits into
mainfrom
DS-663-fix-lock-file

Conversation

@emilyhernandez

Copy link
Copy Markdown
Contributor

DS-663

  • Fixed issue in the package-lock file missing dependencies
  • Added `"type": "module" to ngx package.json to use ESM instead of CommonJS

Developer's checklist

  • I wrote necessary unit tests
  • I updated Storybook stories and documentation to reflect the latest changes
  • I included visual regression tests for new UI design
  • I tested my implementation with different browsers
  • I checked accessibility according to Web Content Accessibility Guidelines 2.1
  • Together with the reviewer I can confirm that the implementation supports the following screenreader and browser combinations (NVDA + Firefox, VoiceOver + Chrome)

@emilyhernandez emilyhernandez self-assigned this Jun 18, 2026
@emilyhernandez emilyhernandez added the dependencies Updating dependencies label Jun 18, 2026
@emilyhernandez emilyhernandez changed the title Ds 663 fix lock file [dependencies]: Fix lock file + change Ngx to type module Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 94%
94.82% (13696/14444) 89.28% (1425/1596) 91.08% (531/583)
Coverage Report • (94%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files94.8289.2891.0894.82 
report-only-changed-files is enabled. No files were changed in this commit :)

@RiinaKuu RiinaKuu merged commit b040b6a into main Jun 18, 2026
14 checks passed
@RiinaKuu RiinaKuu deleted the DS-663-fix-lock-file branch June 18, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Updating dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants