fix(#5074): add preflight dependency check for validation_loop scripts#5192
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#5074): add preflight dependency check for validation_loop scripts#5192fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
When a validation_loop declares a preflight_check command, the runner now executes it during the preflight phase — before sandbox creation. This catches missing host-side dependencies (e.g. python3-jsonschema) immediately instead of after the agent has already completed (~74s of wasted execution). Changes: - Add PreflightCheck field to ValidationLoop struct in the harness schema (preflight_check YAML key) - Execute the check in run.go after ValidateFilesExist but before openshell/sandbox setup - Update all 5 scaffold harness YAML files (triage, review, fix, prioritize, retro) that use validate-output-schema.sh to declare preflight_check for jsonschema - Add unit tests for YAML parsing, preflight execution, and base composition inheritance of the new field Note: pre-commit could not run in this environment (network 403 on hook fetch). The post-script runs an authoritative pre-commit on the runner. Closes #5074
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
Site previewPreview: https://008ce254-site.fullsend-ai.workers.dev Commit: |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a validation_loop declares a preflight_check command, the runner now executes it during the preflight phase — before sandbox creation. This catches missing host-side dependencies (e.g. python3-jsonschema) immediately instead of after the agent has already completed (~74s of wasted execution).
Changes:
harness schema (preflight_check YAML key)
before openshell/sandbox setup
fix, prioritize, retro) that use validate-output-schema.sh
to declare preflight_check for jsonschema
base composition inheritance of the new field
Note: pre-commit could not run in this environment (network 403 on hook fetch). The post-script runs an authoritative pre-commit on the runner.
Closes #5074
Post-script verification
agent/5074-preflight-dep-check)83397e5355462dea996845ed2a1ec019d32f30ac..HEAD)