feat(#325): detect workflow file changes in triage and skip code agent#326
feat(#325): detect workflow file changes in triage and skip code agent#326fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add workflow modification detection to the triage pipeline. When triage identifies that resolving an issue requires changes to GHA workflow files (.github/workflows/, .fullsend/.github/workflows/, or shim workflows), the post-triage script now applies the triaged label instead of ready-to-code, preventing the code agent from being auto-dispatched for work it cannot perform. Changes: - agents/triage.md: add Phase 3 detection guidance and requires_workflow_changes field to triage_summary output - schemas/triage-result.schema.json: add optional boolean requires_workflow_changes to triage_summary definition - scripts/post-triage.sh: check requires_workflow_changes flag and skip ready-to-code for bug/documentation/performance categories when set - scripts/post-triage-test.sh: add 7 tests covering workflow flag behavior across categories and regression guards Closes #325
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 6:59 AM UTC · Completed 7:15 AM UTC |
ReviewFindingsMedium
Low
Labels: PR modifies triage agent behavior (agent instructions, post-script, schema, and tests). |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| # or shim workflows), skip ready-to-code regardless of category. The code | ||
| # agent cannot modify workflow files under current permissions. | ||
| REQUIRES_WORKFLOW=$(jq -r '.triage_summary.requires_workflow_changes // false' "${RESULT_FILE}") | ||
| CATEGORY=$(jq -r '.triage_summary.category // "unknown"' "${RESULT_FILE}") |
There was a problem hiding this comment.
[low] logic-error
The ::warning::Skipping ready-to-code message is emitted before the case statement, firing for all categories when REQUIRES_WORKFLOW is true. For categories that never receive ready-to-code (feature, other, unknown), the warning is misleading.
Suggested fix: Move the warning inside the bug, documentation, and performance case branches, or gate it with a category condition.
fullsend-ai-review
Bot
added
requires-manual-review
2 participants
Summary
requires_workflow_changes: trueis set in the triage summary,post-triage.shappliestriagedinstead ofready-to-code, preventing the code agent from being auto-dispatched for work it cannot perform.github/workflows/,.fullsend/.github/workflows/, and enrolled-repo shim workflowsChanges
agents/triage.md: Added workflow detection guidance in Phase 3 (assessment), addedrequires_workflow_changesfield to thesufficientaction's JSON example, and documented the field's behaviorschemas/triage-result.schema.json: Added optionalrequires_workflow_changesboolean to thetriage_summarydefinitionscripts/post-triage.sh: Added workflow-change guard that checksrequires_workflow_changesand skipsready-to-codelabel for bug/documentation/performance categories when set totruescripts/post-triage-test.sh: Added 7 tests covering workflow flag behavior across all auto-promote categories, regression guards for unflagged issues, and warning output verificationTest plan
yqin sandbox — unrelated to this change)requires_workflow_changes: true→ getstriaged, NOTready-to-codeready-to-code(regression guard)Closes #325
Post-script verification
agent/325-triage-workflow-detection)ca518d9353f5a8363c6ba499d7a2070a1b0e7c5d..HEAD)