fix(#272): remove signing from convention discovery lists#296
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#272): remove signing from convention discovery lists#296fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The fix and code agents non-deterministically add Signed-off-by trailers because both skills instruct agents to discover "signing" conventions from target repos. When a target repo requires DCO signing, the agent sometimes follows the discovered convention instead of the later "NEVER use git commit -s" prohibition. Remove "signing" from the convention discovery bullet in both skills/fix-review/SKILL.md and skills/code-implementation/SKILL.md. The existing prohibitions and post-script hard gates remain as defense-in-depth. Closes #272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fix agent non-deterministically adds
Signed-off-bytrailers because two skill files contain contradictory instructions. The convention-discovery steps tell agents to learn "signing" conventions from target repos, while later prohibitions forbidgit commit -s. When a target repo requires DCO signing, the agent sometimes follows the discovered convention instead of the prohibition, wasting the entire run.This PR removes "signing" from the convention discovery lists in both affected skills:
skills/fix-review/SKILL.md:(message format, signing)→(message format)skills/code-implementation/SKILL.md:signing requirements, message format→message formatThe existing "NEVER use
git commit -s" prohibitions and post-script hard gates remain as defense-in-depth.Testing
make testpasses (one pre-existing failure inpost-triage-test.shunrelated to this change)make check-bundlepassesgit commit -s" prohibitions still exist in both filesCloses #272
Post-script verification
agent/272-remove-signing-discovery)fc7b83e1e64b3d786b2d500189c142759fa06451..HEAD)