fix(#191): remove stale REPO_DIR from harness configs#192
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#191): remove stale REPO_DIR from harness configs#192fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Remove REPO_DIR from forge.github.runner_env in harness/code.yaml
and from forge.github.env.runner in harness/fix.yaml. Since
fullsend#2774 changed sandbox output extraction to a temp
directory, this value pointed to a stale location. The runner
(run.go) already injects the correct REPO_DIR via last-value-wins,
making the harness entries redundant and confusing.
Post-scripts (post-code.sh, post-fix.sh) are unaffected: they
default REPO_DIR with ${REPO_DIR:-repo} and receive the correct
value from the runner injection.
Closes #191
rh-hemartin
previously requested changes
Jul 16, 2026
rh-hemartin
left a comment
rh-hemartin
left a comment
Member
There was a problem hiding this comment.
Blocked until fullsend-ai/fullsend#2774 gets merged.
Member
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 11:35 AM UTC · Completed 11:43 AM UTC |
ReviewFindingsMedium
|
fullsend-ai-review
Bot
added
the
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove REPO_DIR from forge.github.runner_env in harness/code.yaml and from forge.github.env.runner in harness/fix.yaml. Since fullsend#2774 changed sandbox output extraction to a temp directory, this value pointed to a stale location. The runner (run.go) already injects the correct REPO_DIR via last-value-wins, making the harness entries redundant and confusing.
Post-scripts (post-code.sh, post-fix.sh) are unaffected: they default REPO_DIR with ${REPO_DIR:-repo} and receive the correct value from the runner injection.
Closes #191
Post-script verification
agent/191-remove-harness-repo-dir)ab29a63c40f2e235c8b1bdd8152d6083a0dddcc3..HEAD)