Skip to content

SQ2-1052 - feat: allow overriding BASE_URL via constructor kwarg#12

Closed
jmnsf wants to merge 1 commit into
masterfrom
sq2-1052-parametrise-base-url
Closed

SQ2-1052 - feat: allow overriding BASE_URL via constructor kwarg#12
jmnsf wants to merge 1 commit into
masterfrom
sq2-1052-parametrise-base-url

Conversation

@jmnsf

@jmnsf jmnsf commented May 12, 2026

Copy link
Copy Markdown
Contributor

Stacked on #11 (SQ2-1050), which is stacked on #10 (SQ2-1048).

Accepts base_url as a constructor param for easier test server stubbing.

@linear

linear Bot commented May 12, 2026

Copy link
Copy Markdown

SQ2-1052

@jmnsf jmnsf self-assigned this May 12, 2026
@jmnsf jmnsf marked this pull request as ready for review May 12, 2026 14:35
@jmnsf jmnsf force-pushed the sq2-1050-harden-errors branch from a2f977d to 79ff5ba Compare May 13, 2026 10:52
@jmnsf jmnsf force-pushed the sq2-1052-parametrise-base-url branch from e6f38ce to b07db3f Compare May 13, 2026 10:56
@jmnsf jmnsf changed the base branch from sq2-1050-harden-errors to master May 13, 2026 10:57
@jmnsf

jmnsf commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #14

@jmnsf jmnsf closed this May 13, 2026
@jmnsf jmnsf deleted the sq2-1052-parametrise-base-url branch May 13, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant