Skip to content

new approach #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fulldecent wants to merge 3 commits into
base: main
Choose a base branch
from
Open

new approach #188

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4711b2c
new approach
fulldecent Jul 30, 2026
d0972ea
drop feature
fulldecent Jul 30, 2026
df11875
cut to rvm
fulldecent Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@
"name": "Jekyll",
"image": "mcr.microsoft.com/devcontainers/jekyll",
"features": {
// Install rbenv (no Ruby yet); postCreateCommand installs the version from .ruby-version
"ghcr.io/devcontainers/features/ruby:2": {
"version": "none",
"versionManager": "rbenv"
},
// Install nvm (no Node yet); postCreateCommand installs the version from .nvmrc
"ghcr.io/devcontainers/features/node:2": {
"version": "none",
Expand All @@ -20,7 +15,8 @@
}
},
// Ruby and Node versions come from .ruby-version and .nvmrc (single source of truth, shared with CI)
"postCreateCommand": "/bin/bash -c 'set -e; rbenv install --skip-existing; rbenv rehash; source \"$NVM_DIR/nvm.sh\"; nvm install; nvm use; npm install -g corepack; corepack enable; corepack prepare yarn@4.18.0 --activate; yarn install --immutable; bundle install'",
// We depend on the Jekyll image having RVM + ruby-build installed
"postCreateCommand": "bash -lc 'set -e; source /usr/local/rvm/scripts/rvm; rvm install \"$(tr -d \"[:space:]\" < .ruby-version)\"; rvm use \"$(tr -d \"[:space:]\" < .ruby-version)\" --default; . \"$NVM_DIR/nvm.sh\"; nvm install; nvm use; npm install -g corepack; corepack enable; corepack install; yarn install --immutable; bundle install'",
"customizations": {
"vscode": {
"extensions": ["html-validate.vscode-html-validate"]
Expand Down