Skip to content

Extract test-test workflow with correct job prerequisites #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fulldecent merged 4 commits into from
Sep 16, 2025
Merged

Extract test-test workflow with correct job prerequisites #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1af3c4a
Initial plan
Copilot Sep 16, 2025
8d73a6d
Extract test-test workflow and separate test tools validation
Copilot Sep 16, 2025
c57bf00
Run yarn lint-fix to fix formatting issues
Copilot Sep 16, 2025
5c4ce62
Fix workflow prerequisites: test-test is prerequisite for test, only …
Copilot Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .github/workflows/build-test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,36 @@ jobs:
path: build/ # the Jekyll build directory
include-hidden-files: true # Workaround https://github.com/actions/upload-artifact/issues/610

# Test the test tools themselves
test-test:
name: Test tools validation
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

# Installing Node + modern Yarn on GitHub Actions requires hack
# https://github.com/actions/setup-node/issues/531#issuecomment-2960522861
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
- name: Enable Corepack
run: corepack enable
- name: Configure dependency cache
uses: actions/setup-node@v4
with:
cache: yarn
- name: Install dependencies
run: yarn install --immutable

- name: Test test tools
run: yarn run test-test

# Test the build artifact
test:
name: Test
runs-on: ubuntu-latest
needs: build
needs: [build, test-test]
steps:
- uses: actions/checkout@v4

Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"structured-data-testing-tool": "^4.5.0"
},
"scripts": {
"test": "yarn node test/fixtures-html-validate-should-fail.mjs && yarn node test/fixtures-structured-data-should-fail.mjs && yarn node test/build-html-validate.mjs && yarn node test/dirty-file-paths-checker.mjs && yarn node test/build-structured-data-validate.mjs",
"test": "yarn node test/build-html-validate.mjs && yarn node test/dirty-file-paths-checker.mjs && yarn node test/build-structured-data-validate.mjs",
"test-test": "yarn node test/fixtures-html-validate-should-fail.mjs && yarn node test/fixtures-structured-data-should-fail.mjs",
"test-structured-data": "yarn node test/build-structured-data-validate.mjs",
"lint": "yarn prettier-check && yarn markdownlint-check",
"lint-fix": "yarn prettier-fix && yarn markdownlint-fix",
Expand Down
Loading