feat: support juniper 0.17#2
Open
li-yifei wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates juniper-compose to work with Juniper 0.17.x by aligning both crate dependencies and macro-generated trait impls with Juniper’s updated APIs, and adds a basic integration test to validate composed query behavior.
Changes:
- Bump
juniper-compose/juniper-compose-macrosversions to0.17.0and update the Juniper dependency to0.17.1. - Update macro expansions to match Juniper 0.17 trait signatures (e.g.,
ArcStr, updatedRegistry/MetaTypesignatures). - Add an integration test exercising a composed
Queryexposing fields from multiple composable objects.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
juniper-compose/tests/compose.rs |
Adds an integration test validating a composed query exposes all fields. |
juniper-compose/src/lib.rs |
Adjusts docs/doctest fences and simplifies type_to_owned for Juniper 0.17 Type behavior. |
juniper-compose/Cargo.toml |
Bumps crate + dependency versions for Juniper 0.17 support. |
juniper-compose-macros/src/lib.rs |
Updates generated Juniper trait impls to match 0.17 API changes. |
juniper-compose-macros/Cargo.toml |
Bumps macro crate version to 0.17.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| impl ::juniper::GraphQLType for #name { | ||
| fn name(info: &Self::TypeInfo) -> ::std::option::Option<&str> { | ||
| ::std::option::Option::Some(#name_lit) | ||
| fn name(info: &Self::TypeInfo) -> ::std::option::Option<::juniper::ArcStr> { |
Comment on lines
+46
to
+49
| assert_eq!( | ||
| value.to_string(), | ||
| "{\"userName\": \"alice\", \"taskCount\": 3}" | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.