feat(rules): add Azure & GCP service-account key patterns to secret detector (#93)#99
Open
stevenmini2019 wants to merge 2 commits into
Open
Conversation
…etector (fu351#93) - Detect Azure Storage AccountKey= and Service Bus/IoT SharedAccessKey= in connection strings - Detect GCP service-account JSON marker ("type": "service_account") and SA client email (*.iam.gserviceaccount.com) - Add detection tests (BLOCK on exfil) + precision guards (no over-block on benign lookalikes) - All 63 secrets-rule tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #93.
Adds detection for cloud service-account credential shapes that the original
_CREDENTIAL_PATTERNSmissed:AccountKey=...(44-char base64)SharedAccessKey=..."type": "service_account"<name>@<project>.iam.gserviceaccount.comTest plan
AZURE_GCP_CREDENTIALSdetection cases (BLOCK on exfiltration) andAZURE_GCP_BENIGNprecision guards (no over-block on ordinary emails / benign lookalikes).All fake values are synthetic and split via
+so GitHub push-protection / gitleaks CI stays clean.