test(engine): add Hypothesis laws for combine#98
Open
leemeo3 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice
combine()What this PR does
random.Randomfuzz loop intests/unit/test_verdict_ordering.pywith Hypothesis property tests.Verdict x VerdictandRisk x Riskmatrices.hypothesisto thedevextra.Fixes #96
Tests added (run in CI)
tests/unit/test_verdict_ordering.py— Hypothesis strategy builds validGuardrailResultvalues and exercises the raise-only, commutative, associative, and idempotent laws.Local validation:
.venv/bin/python -m pip install -e ".[dev]".venv/bin/python -m pytest tests/unit/test_verdict_ordering.py -v— 36 passed.venv/bin/ruff check ..venv/bin/ruff format --check ..venv/bin/lint-imports.venv/bin/python -m pytest --cov=doberman --cov-report=term-missing— 1370 passed, 2 skipped, 91% coveragePublic-release safety (doberman-core only)
Security checklist
lint-importskept both contractsEdge cases covered / Deviations from plan / Risks introduced
combine()intentionally preserves operand order in the merged reason list.AI assistance: Prepared with OpenAI Codex.