feat(policy): record mode-dial changes in the drift ledger via log_change#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice
Closes #79
What this PR does
doberman mode <m>and the setup wizard calledconfig.save_mode()directly — aparanoid → lightdowngrade recorded nothing. Both user-initiated call sites now route through a shared_apply_mode_changehelper that audit-logs viadrift.log_change(the scope-enforced, audited-but-not-gated path from #72) before saving:weaken/method="logged"rows indoberman policy-history; upgrades asstrengthen.resolve_moderaises before anything happens).Test-fixture
save_modecalls (6 test files) were deliberately left unwired — not user-initiated.Tests added (run in CI)
tests/unit/test_mode_ledger.py(4): downgrade→weaken row · upgrade→strengthen row · same-mode records nothing · monkeypatched ledger failure → warning + mode still applied.Security checklist
Notes
Pre-existing doc bug spotted (out of scope, not fixed here): README references
doberman policy set-mode <mode>, but the actual command isdoberman mode <name>.