Skip to content

Add upath.implementations.cloud.HfPath#457

Merged
ap-- merged 9 commits into
fsspec:mainfrom
lhoestq:add-hf
Nov 9, 2025
Merged

Add upath.implementations.cloud.HfPath#457
ap-- merged 9 commits into
fsspec:mainfrom
lhoestq:add-hf

Conversation

@lhoestq

@lhoestq lhoestq commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

e.g. for paths like hf://datasets/google/svq/audio/utts_gu_in_clean.parquet which is inside the google/svq dataset

let me know if tests are needed, we can have an account for fsspec on HF for the CI to use

@ap--

ap-- commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator

Thank you for contributing @lhoestq

let me know if tests are needed, we can have an account for fsspec on HF for the CI to use

That would be ideal. From experience there are usually some edge cases that need adjustments.
The name should probably be chosen so that it's clear the account is only used for tests. I assume there's no way to locally mock the hf hub api?

Cheers,
Andreas

@lhoestq

lhoestq commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

I assume there's no way to locally mock the hf hub api?

Actually I can easily patch HfApi.repo_info and HfApi.list_repo_tree which are enough to test read-only features, would it be ok ?

@ap--

ap-- commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator

Yes! If that's easy to do we could start with readonly tests.

@lhoestq

lhoestq commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

I just added readonly tests :)

@ap--

ap-- commented Nov 9, 2025

Copy link
Copy Markdown
Collaborator

Thank you @lhoestq 🙏 ❤️

@ap--
ap-- merged commit 7e51c6a into fsspec:main Nov 9, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants