Change protocol check to fallback for known implementations#449
Closed
hadim wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hi @hadim Thanks for the PR! The check is intended:
I am working to get full simplecache support for the next release #445 which once finalized will include removal of the warning for chained |
Author
|
Ok sorry for the noise then! Thanks. |
Collaborator
|
works now in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code below:
triggers this one-time warning:
which I think is a false positive due to a typo.
But I am not sure and maybe I misunderstand the logic here so let me know!
Using the latest version of upath.