feat: allow deriving Deref[Mut] for structs with multiple fields#1
Open
dquirl-R1 wants to merge 1 commit into
Open
feat: allow deriving Deref[Mut] for structs with multiple fields#1dquirl-R1 wants to merge 1 commit into
dquirl-R1 wants to merge 1 commit into
Conversation
allow selecting the target field for Deref and DerefMut by annotating it with a `#[deref]` helper attribute like is done for enum variants with `#[default]` the implementation checks how many fields are annotated with the attribute so more than one target is disallowed and is backwards-compatible with the current "single-field" behaviour as the attribute is not required for single-field structs
Author
|
I looked at the other derives to see if any have similar "parameter-less" helper attributes and tried to match the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow selecting the target field (and type) for
DerefandDerefMutby annotating one of the struct fields with a#[deref]helper attribute.The implementation checks how many fields are annotated with the attribute so more than one target remains disallowed. This is backwards-compatible with the current "single-field" behaviour as the attribute is not required for single-field structs, which still fall back to their only field automatically.