-
Notifications
You must be signed in to change notification settings - Fork 160
Hawk Camera Support #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
austinc3030
wants to merge
7
commits into
fronzbot:dev
Choose a base branch
from
dynacylabs:feature/hawk-camera-support
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hawk Camera Support #1272
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5ea5053
Add Blink Arc (Hawk) camera support
austinc3030 4537298
Fix test_blinkpy assertions to use actual camera IDs after owl/lotus …
austinc3030 6a9358d
Fix PLC0415: move BlinkCameraHawk to top-level import in sync_module
austinc3030 e3095ec
Fix hawk API routing to use /hawks/ endpoint; preserve product_type i…
austinc3030 aedd3c3
Fix Black formatting in test_api and test_blinkpy
austinc3030 451dd1d
Merge branch 'fronzbot:dev' into feature/hawk-camera-support
austinc3030 0a063cb
Fix camera_type mutation across loop iterations in update_cameras()
austinc3030 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in commit 0a063cb —
update_cameras()now uses a localresolved_camera_typeper iteration instead of mutating thecamera_typeparameter, preventing class leakage between loop iterations.