Show visible feedback while auto-scroll is active#14
Open
damiangonzalez wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When auto-scroll is activated there is no visible indication that the mode is on. The app calls
NSCursor.hide()/scrollCursor?.set(), but a background menu bar app cannot change the pointer over other apps' windows, so the custom cursor never actually appears. Users activate auto-scroll (especially via middle click or utilities like MiddleClick that synthesize middle clicks on trackpads) and have no way to tell whether the mode is active except by moving the mouse and seeing whether the page scrolls.Change
Adds visual feedback for every activation path (middle click and variants, trackpad Option+scroll, and the menu bar toggle), all cleared when auto-scroll stops. Two commits, one file (
ScrollappApp.swift), no behavior changes otherwise:arrow.up.and.down.circle.fillsymbol at the activation point, similar to the Windows auto-scroll origin marker. It ignores mouse events, floats above other windows, and joins all Spaces.The existing trackpad-mode notification is left unchanged.
Testing
Manual (the repo has no committed Xcode project or runnable test target, so no automated tests could be added):
Notes
NSPanelwith.nonactivatingPanelavoids stealing focus from the frontmost app.isReleasedWhenClosed = falseprevents over-release since the panel is owned by the strong property.