Conversation
rebuild patch based on new openwrt developments in ath79
AiyionPrime
requested changes
Jun 2, 2026
AiyionPrime
left a comment
AiyionPrime
left a comment
Member
There was a problem hiding this comment.
For an easier review, it might be useful to do this as two commits:
one that reverts the removal of the old commit and one that's your update :)
Comment on lines
+945
to
+947
| -- | ||
| 2.47.3 | ||
|
|
Member
There was a problem hiding this comment.
@Dark4MD You tend to add windows line endings to files, as well as metadata from your PC,
CI won't be able to do either.
If you look at the workflow in .github/ directory, you'll find the command to build the patches like our pipeline does :)
If we'd merge it like this, we'd lose the ability to attest their applicability :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebuild patch based on new openwrt developments in ath79
works for me and bernd in testbuilds