feat: Use dom99 for testrouters#124
Conversation
unhide the secondary domain to actually see it in configmode and prefix the domain name with ~ to place it last in the dropdown.
1977er
left a comment
There was a problem hiding this comment.
LGTM (looked, got tired, merged) ;-)
|
Thankfully you're still learning to wield GitHubs power - you did not merge 😁 |
|
Ick wes, aber ich habe heute die Abk. neu gelernt und wollte mein neues Wissen anwenden. |
|
Looks good to me :) (Not using the abrrev any more, since it just became ambiguous) |
|
@lemoer The ordering has not been tested, yet. |
|
|
||
| domain_names = { | ||
| leetfeld = 'Leetfeld (1337, invalid)', | ||
| testing = '~Testrouter', |
There was a problem hiding this comment.
Did you test that this results in being shown at the end? Or was it based on some assumption?
|
Ok, I added it to the list of tests, which we want to do before we do the release. So, we could merge this without testing this particular thing before merge, if we want to. |
|
I'm fine either way. |
|
Maybe the SSID and the Domain name not so much fixated on Routers and more like "experimental" or "labor" or simply "Test" and the ssid maybe test.ffh.zone which links to grafana or the releases page? Or maybe a small landing page that instructs someone that happens to see this SSID can get more Infos on what happens here ;). |
|
I'd like the domain to be unattractive for regular users. The SSID idea I like a lot; I just avoided hannover.freifunk.net to avoid confusion. |
in order to not interfere with productve devices. This commit does not endorse the idea for deviating SSIDs per domain in general.
10cebfe to
b3865b6
Compare
|
MT7621 produces build failures on master for me, gotta look into this. |
This week @lemoer and I discussed how we could minimize the disruptive impact of (permanent) testing routers in or near productive Freifunk installations such as the one in the LeineLab.
We came to the conclusion using a different domain would allow use to use different SSIDs for testing.