Handle signals using sd-event#7
Open
ahmubashshir wants to merge 3 commits into
Open
Conversation
ahmubashshir
commented
Mar 5, 2026
ahmubashshir
commented
- Handle signals properly using sd-event
- Add structured, compile-time debug logging
Use`sd-event` to process signals, as `sd_bus_wait()` blocked all signals except `KILL` due to internal `ppoll` call. Signed-off-by: Mubashshir <ahmubashshir@gmail.com>
Implemented structured logging with multiple levels (DEBUG, INFO, WARN, ERROR, FATAL). Replaced error handling with `ABORT()` for better logging and termination on critical errors. Signed-off-by: Mubashshir <ahmubashshir@gmail.com>
ahmubashshir
force-pushed
the
sd-event-signal
branch
from
f7b31ee to
c163b13
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refactors the build and runtime to support optional debug logging and migrates the main loop from manual sd_bus_wait/process to a systemd sd-event driven loop.
Changes:
- Introduces a shared
c_argslist in Meson and conditionally definesENABLE_DEBUG. - Adds structured logging helpers/macros and extra debug statements.
- Switches main execution to
sd_event_loop()and attachessd-bus+ signal handling to that event loop.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| meson.build | Centralizes compiler flags and adds conditional -DENABLE_DEBUG for debug builds. |
| jelling.c | Adds logging utilities and migrates runtime control flow to sd-event with signal integration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Mubashshir <ahmubashshir@gmail.com>
ahmubashshir
force-pushed
the
sd-event-signal
branch
4 times, most recently
from
55c05e1 to
2efb12c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.