donate: add /donate/thanks/ page and redirect /join to it#51
Merged
Conversation
A donor reported that their PayPal donation returned them to freenet.org/join?donated=yes, which 404s — no /join page has existed on the Hugo site for years. The return URL is stored inside the PayPal hosted button's saved configuration (button_id=EQ9E7DPHB6ETY), not in our page code. Add a proper /donate/thanks/ thank-you page so future donations can land on something real once we update the PayPal Auto Return setting to point to it. Also alias /join/ -> /donate/thanks/ as a safety net for the in-flight broken URL and any cached PayPal email receipts that link to /join. [AI-assisted - Claude]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A donor reported their PayPal donation returned them to
freenet.org/join?donated=yes, which 404s — no/joinpage has existed on the Hugo site for years.The return URL is stored inside the PayPal hosted button's saved configuration (button_id
EQ9E7DPHB6ETY), not in our page code (only PayPal reference in the repo is the donate link itself, noreturn=param).Changes
hugo-site/content/donate/thanks/_index.md— a proper thank-you page for completed donations.aliasesfrontmatter to redirect/join/→/donate/thanks/, so the existing broken URL works (safety net for cached PayPal receipts and the window before any PayPal-side fix takes effect).Follow-up (PayPal side, not in this PR)
Set the account-level Auto Return URL in PayPal to
https://freenet.org/donate/thanks/(under Account Settings → Website Payments / Website Preferences). This overrides the per-button return URL embedded inEQ9E7DPHB6ETYso we don't have to hunt for that hosted button in PayPal's UI.Test plan
hugobuild succeeds.public/join/index.htmlis generated with a meta-refresh to/donate/thanks/.public/donate/thanks/index.htmlis generated.curl -I https://freenet.org/joinreturns 200 with the redirect HTML, andhttps://freenet.org/donate/thanks/renders the page.[AI-assisted - Claude]