fix(ui): style contact modals in inbox view, overlay Settings, default verify-on-send off#262
Merged
Merged
Conversation
…t verify-on-send off Three related fixes to the Import/Share contact modals reachable from Settings → Contacts (the .fm-app scope): 1. Form fields rendered unstyled in the inbox view. The modal markup uses .field/.input/.textarea/.verify-words*/.token-block/.verify-check* classes that only existed under login.css @scope (.fm-pre). The Settings → Contacts render site lives under @scope (.fm-app), where only .veil/.modal-* were mirrored, so labels rendered inline-left of inputs and the textarea overlapped its label. Mirror the missing rules into settings.css's .fm-app block. 2. Opening Import/Share called close_settings() first (from #97, before the modal CSS worked in .fm-app), dropping the background to the inbox. Remove that so the modal overlays the Contacts panel instead. 3. "Require known key to send" (verify_on_send) now defaults off — it was blocking sends to any not-yet-verified contact out of the box. Comments in the live-node / repro Playwright specs and the QA inventory updated to reflect the new default (tests still tick verify explicitly, so behavior is unchanged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three related fixes to the Import / Share contact modals reachable from Settings → Contacts (the
.fm-appscope).1. Modals rendered unstyled in the inbox view
The modal markup uses
.field/.input/.textarea/.verify-words*/.token-block/.verify-check*classes that only existed underlogin.css@scope (.fm-pre). The Settings → Contacts render site lives under@scope (.fm-app), where only.veil/.modal-*were mirrored — so labels rendered inline-left of inputs and the textarea overlapped its label.Fix: mirror the missing form-field / verify / token rules into
settings.css's.fm-appblock.2. Opening a modal dropped to the inbox
on_import/on_sharecalledclose_settings()before opening the modal (from #97, predating the.fm-appmodal CSS). Background reverted Settings → inbox. Removed it — modal now overlays the Contacts panel.3.
verify_on_senddefaulted on"Require known key to send" now defaults off. It was blocking sends to any not-yet-verified contact out of the box.
Verification
cargo test -p mail-local-state— 28/28 pass (default-flip assertion updated)example-data,no-sync)Playwright spec comments +
docs/qa/manual-test-inventory.mdupdated for the new default (specs still tick verify explicitly, so behavior unchanged).