Skip to content

Valueupdate after load #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
defiantnerd merged 4 commits into from
Aug 8, 2026
Merged

Valueupdate after load #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2f24f1
adding update of parameter values after load
defiantnerd Aug 4, 2026
bbb6578
fixing a small issue when param_rescan is called with other flags, de…
defiantnerd Aug 5, 2026
4370405
renaming the variable and added a few checks
defiantnerd Aug 8, 2026
c4f5f43
Merge branch 'next' into valueupdate_after_load
defiantnerd Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/wrapasvst3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,13 +271,14 @@ tresult PLUGIN_API ClapAsVst3::canProcessSampleSize(int32 symbolicSampleSize)
tresult PLUGIN_API ClapAsVst3::setState(IBStream *state)
{
auto raise = _plugin->AlwaysMainThread();
_param_rescan_has_been_called = false; // detect rescan/reload during load
// a plugin may request a value rescan from within load(), which syncs the values for us
_paramValuesSyncedDuringLoad = false;

auto result =
(_plugin->load(CLAPVST3StreamAdapter(state)) ? Steinberg::kResultOk : Steinberg::kResultFalse);

// if the state was loaded correctly, values must be updated
if (result == kResultOk && !_param_rescan_has_been_called)
if (result == kResultOk && !_paramValuesSyncedDuringLoad)
{
syncParameterValuesFromClap();
}
Expand Down Expand Up @@ -1244,13 +1245,14 @@ void ClapAsVst3::param_rescan(clap_param_rescan_flags flags)

if (vstflags == 0) return;

// check this in ::setState
_param_rescan_has_been_called = true;
// every path from here on syncs the values, which ::setState relies on -
// keep this assignment below the early-out above
_paramValuesSyncedDuringLoad = true;

// update parameter values in our own tree
syncParameterValuesFromClap();

if (flags & CLAP_PARAM_RESCAN_INFO)
if ((flags & CLAP_PARAM_RESCAN_INFO) && _plugin->_ext._params)
{
// In this case, the name and module can also change.
// For now, don't rebuild the unit tree with modules but
Expand All @@ -1268,7 +1270,9 @@ void ClapAsVst3::param_rescan(clap_param_rescan_flags flags)
}
}

this->componentHandler->restartComponent(vstflags);
// a plugin can request a rescan from within state load(), which a host may
// call before it hands us the component handler
if (this->componentHandler) this->componentHandler->restartComponent(vstflags);
}

void ClapAsVst3::param_clear(clap_id param, clap_param_clear_flags flags)
Expand Down
3 changes: 2 additions & 1 deletion src/wrapasvst3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,8 @@ class ClapAsVst3 : public Steinberg::Vst::SingleComponentEffect,
// the queue from audiothread to UI thread
ClapWrapper::detail::shared::fixedqueue<queueEvent, 8192> _queueToUI;

bool _param_rescan_has_been_called{false};
// set by param_rescan() whenever it syncs values, cleared and checked by setState()
bool _paramValuesSyncedDuringLoad{false};

// for IMidiMapping
bool _useIMidiMapping = false;
Expand Down
Loading