AUv3: clear created state when GUI creation fails - #501
Merged
defiantnerd merged 1 commit intoAug 8, 2026
Conversation
Collaborator
|
Thank you very much! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AUv3 wrapper sets
_guiCreatedbefore callingcreateGUIInView. If the plugin'screate()returns false, the next layout still callscan_resize()on a GUI that was never created.The proposed change clears
_guiCreatedwhen creation fails. It stays set during the call, so the existing reentrancy guard is preserved.Tested with a modified clap-first plugin whose GUI create() returns false. Before this change,
viewDidLayoutcalledcan_resize()and the fixture aborted. After the change, creation fails cleanly and no later GUI callbacks are made.