Skip to content

fix: randomize hidden params in fuzzer #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quant1um merged 2 commits into from
Jul 24, 2026
Merged

fix: randomize hidden params in fuzzer #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a0443f
fix: randomize hidden params too
lxndrbe Jul 13, 2026
98fca59
fix: remove remaining is_hidden() checks in fuzzer
lxndrbe Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/tests/rng.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ impl<'a> NoteGenerator<'a> {

let Some((param_id, param)) = params
.iter()
.filter(|(_, param)| !param.is_readonly() && !param.is_hidden() && param.is_poly_automatable())
.filter(|(_, param)| !param.is_readonly() && param.is_poly_automatable())
.choose(prng)
else {
continue;
Expand Down Expand Up @@ -713,7 +713,7 @@ impl<'a> NoteGenerator<'a> {

let Some((param_id, param)) = params
.iter()
.filter(|(_, param)| !param.is_readonly() && !param.is_hidden() && param.is_poly_modulatable())
.filter(|(_, param)| !param.is_readonly() && param.is_poly_modulatable())
.choose(prng)
else {
continue;
Expand Down Expand Up @@ -864,7 +864,7 @@ impl<'a> ParamFuzzer<'a> {
let (param_id, param_info) = self
.params
.iter()
.filter(|(_, info)| !info.is_readonly() && !info.is_hidden())
.filter(|(_, info)| !info.is_readonly())
.choose(prng)?;

if !self.snap_to_bounds && param_info.is_modulatable() && prng.random_bool(0.5) {
Expand Down Expand Up @@ -921,7 +921,7 @@ impl<'a> ParamFuzzer<'a> {
// We can send parameter changes for parameters that are not automatable:
//
// > The host can send live user changes for this parameter regardless of this flag.
if param_info.is_readonly() || param_info.is_hidden() {
if param_info.is_readonly() {
return None;
}

Expand Down