compatibility fix for modern CMake versions - #57
Open
cccfire wants to merge 1 commit into
Open
Conversation
|
|
cccfire
marked this pull request as ready for review
February 22, 2026 17:16
Contributor
|
I've updated the vcpkg submodule, is this change still required? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern CMake versions have removed compatibility with projects marked with CMake versions <3.5, which affects some of the dependencies in this project and results in an error.
This PR adds the configuration flag
-DCMAKE_POLICY_VERSION_MINIMUM=3.5to the build for x64 windows.The same fix should work for other systems, should they run into this issue, but this is the only environment I have access to at the moment and can confirm the fix with.