fix: add 'unknown' to PresenceStatus type#28
Merged
Conversation
The type was missing the 'unknown' variant used in FindUser and BuddyList for users whose presence state hasn't been received yet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Test files import from 'vitest' which isn't available to svelte-check. Exclude *.test.ts from the main tsconfig so they're only type-checked by vitest itself. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Change <label>To:</label> to <span> (not associated with a control) - Add role="article" to message divs with contextmenu handlers - Add href and role="button" to file download <a> elements Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'unknown'to thePresenceStatusunion type insrc/lib/types.tsFindUser.svelteandBuddyList.sveltethat were failingsvelte-checkin CIThe
'unknown'state is used for users whose presence hasn't been received yet (e.g., direct user ID entry in FindUser, or initial buddy list load).Test plan
npx svelte-check --tsconfig ./tsconfig.jsonpasses with 0 errors🤖 Generated with Claude Code