Skip to content

Remove enforced styles - #71

Merged
Frequinzy merged 2 commits into
mainfrom
fix-lyrics-alignment
Apr 10, 2026
Merged

Remove enforced styles#71
Frequinzy merged 2 commits into
mainfrom
fix-lyrics-alignment

Conversation

@frblo

@frblo frblo commented Apr 8, 2026

Copy link
Copy Markdown
Owner

Fixes a bug lyric elements were aligned right-to-left in the pdf output, which it should not be. Also removes enforced styles (like UPPERCASE, italics, etc.) on elements in the html export.

Fixes a bug lyric elements were aligned right-to-left in the `pdf`
output, which it should not be.
@frblo
frblo requested a review from Frequinzy April 8, 2026 20:54
@frblo frblo added the bug Something isn't working label Apr 8, 2026
@frblo
frblo marked this pull request as ready for review April 8, 2026 20:54

@Frequinzy Frequinzy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should also make the lyrics string uppercase to match what the html output does with lyrics.

@frblo

frblo commented Apr 9, 2026

Copy link
Copy Markdown
Owner Author

Perhaps we should also make the lyrics string uppercase to match what the html output does with lyrics.

I have thought about it and come to the conclusion that I don't think we should do that, probably not in the html output either. I feel that Rustwell exports primarily should force the margins and such on the user content, but other than that it should be up to the user to make sure that they follow the screenplay standard they choose to follow (as there is no single standard standard). This is also why I think it's good that almost everything the user writes is a RichString so that the user can choose to have formatting in all elements, even thought it's not necessarily "standard".

@Frequinzy

Copy link
Copy Markdown
Collaborator

Then perhaps this PR should remove it from the css as well?

@frblo frblo changed the title Align lyrics in pdf left-to-right Remove enforced styles Apr 10, 2026
@frblo
frblo requested a review from Frequinzy April 10, 2026 11:13

@Frequinzy Frequinzy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Frequinzy
Frequinzy merged commit 4d59a45 into main Apr 10, 2026
1 check passed
@Frequinzy
Frequinzy deleted the fix-lyrics-alignment branch April 10, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants