feat(stripe): shared infrastructure for the stripe refactor#237
feat(stripe): shared infrastructure for the stripe refactor#237Tarunkumar0601 wants to merge 2 commits into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Confidence Score: 4/5Safe to merge as infrastructure with one outstanding crash path: if a Subscription Plan referenced in a Subscription Plan Detail row is later deleted, the bare tuple unpack in stripe_checkout.py line 51 raises TypeError on the checkout page. The stripe_checkout.py change unpacks the result of frappe.db.get_value directly into billing_interval, billing_interval_count with no guard against a None return — a deleted or missing plan silently crashes the checkout page with a TypeError. This risk was flagged in a prior review thread but remains unaddressed. payments/templates/pages/stripe_checkout.py — tuple unpack of frappe.db.get_value on line 51 needs a None guard before unpacking. Reviews (6): Last reviewed commit: "feat(stripe): shared infrastructure for ..." | Re-trigger Greptile |
64d872a to
a0713ef
Compare
05f9e99 to
965c6eb
Compare
965c6eb to
9e18445
Compare
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
| if not gw or gw.gateway_settings != "Stripe Settings": | ||
| return None | ||
| if not gw.gateway_controller: | ||
| # Gateway relies on the naming-convention fallback; | ||
| return None |
9e18445 to
b67c9de
Compare
Foundation for the Stripe integration refactor — no behaviour change on its own.
Backport Needed: V15 & V16