fix(stripe): remove unknown column payment_plan in field list#236
Open
Tarunkumar0601 wants to merge 1 commit into
Open
fix(stripe): remove unknown column payment_plan in field list#236Tarunkumar0601 wants to merge 1 commit into
Tarunkumar0601 wants to merge 1 commit into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Confidence Score: 5/5This looks safe to merge.
Reviews (3): Last reviewed commit: "fix(stripe): remove unknown column payme..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Tarunkumar0601
force-pushed
the
fix/stripe-subscription-creation
branch
from
90eb56e to
764318f
Compare
Sudharsanan11
suggested changes
Jul 8, 2026
Sudharsanan11
left a comment
Sudharsanan11
left a comment
There was a problem hiding this comment.
Avoid using db.get_value in for loop and don't use get_doc to fetch single child value.
| cadences = { | ||
| (billing_interval, cint(billing_interval_count) or 1) | ||
| for billing_interval, billing_interval_count in ( | ||
| frappe.db.get_value( |
There was a problem hiding this comment.
Use get_all instead of db.get_value
| # Read plans from the same source the payment flow charges against | ||
| # (Payment Request.subscription_plans) so the displayed recurrence | ||
| # can't diverge from what is actually billed. | ||
| reference = frappe.get_doc(context.reference_doctype, context.reference_docname) |
Tarunkumar0601
force-pushed
the
fix/stripe-subscription-creation
branch
from
764318f to
1ffddc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Stripe Checkout failure caused by the deprecated payment_plan field reference in the Stripe checkout flow.
Update the implementation to use the current subscription_plans child table structure, ensuring subscription details are retrieved correctly during checkout and maintaining compatibility with the latest ERPNext Payments data model.
Ref: #90
Backport Needed: V15 & V16