feat: add PaymentController v2 architecture by 0spinboson · Pull Request #192 · frappe/payments

feat: add PaymentController v2 architecture

0spinboson

committed

docs: design spec for recurring/mandated payments extension

0spinboson

committed

docs: TDD implementation plan for mandate framework (Phases A+B)

0spinboson

committed

docs: reserve mandate_acquisition + shared initiation core; add ARCHITECTURE.md

0spinboson

committed

test(payments): add SDK-free reference/demo PaymentController gateway

0spinboson

committed

test(payments): retarget lifecycle tests to demo gateway (Stripe-independent)

0spinboson

committed

refactor(payments): extract make_error_processed helper in process_response (DRY)

0spinboson

committed

refactor(payments): extract _redirect_on_initiation_error helper in proceed (DRY)

0spinboson

committed

refactor(payments): promote compensatory-action closure to method (DRY)

0spinboson

committed

refactor(payments): add GatewayRef dataclass for gateway identity (DRY)

0spinboson

committed

refactor(payments): use self.state.response consistently; drop dup TYPE_CHECKING import

0spinboson

committed

docs: drop mandate-feature planning docs from the architecture branch

0spinboson

committed

fix(payments): handle PSL lock contention in process_response

0spinboson

committed

fix(payments): surface unmapped status as handled error in _process_response

0spinboson

committed

fix(payments): read HTTPError body from exception in proceed

0spinboson

committed

fix(payments): align PSL status schema default with code state

0spinboson

committed

fix(payments): resolve PSL controller uncached to avoid state bleed

0spinboson

committed

fix(payments): validate TxData when merging updates into PSL

0spinboson

committed

fix(payments): purge all terminal PSL logs, not just Paid

0spinboson

committed

fix(payments): resolve controller via get_doc in initiate() too

0spinboson

committed

fix(payments): stop leaking gateway secrets into guest /pay templates

0spinboson

committed

fix(payments): escape user-influenced vars in /pay (stored XSS)

0spinboson

committed

fix(payments): minimize payer PII persisted in Payment Session Log

0spinboson

committed

fix(payments): return opaque correlation code, not Error Log name, to guests

0spinboson

committed

fix(payments): restrict guest select_button to POST (CSRF hardening)

0spinboson

committed

fix(security): complete M4 on the button-not-found path in select_button

0spinboson

committed

refactor(payments): extract _invoke_ref_doc_hook from _process_response

0spinboson

committed

refactor(payments): dedup PSL initiation setters via _set_initiation_state

0spinboson

committed

refactor(payments): PSLName/PaymentUrl str subclasses -> TypeAlias

0spinboson

committed

refactor(payments): validate controller invariants in __init_subclass__

0spinboson

committed

fix(types): correct TxData.loyalty_points annotation (tuple, not list[str, float])

0spinboson

committed

docs(payments): note __init_subclass__ definition-time behavior re abstract intermediates

0spinboson

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add PaymentController v2 architecture#192

feat: add PaymentController v2 architecture#192
0spinboson wants to merge 32 commits into
frappe:developfrom
nlvegan:refactor/payment-controller-architecture

Commits on Jun 13, 2026

feat: add PaymentController v2 architecture

docs: design spec for recurring/mandated payments extension

docs: TDD implementation plan for mandate framework (Phases A+B)

docs: reserve mandate_acquisition + shared initiation core; add ARCHITECTURE.md

test(payments): add SDK-free reference/demo PaymentController gateway

test(payments): retarget lifecycle tests to demo gateway (Stripe-independent)

refactor(payments): extract make_error_processed helper in process_response (DRY)

refactor(payments): extract _redirect_on_initiation_error helper in proceed (DRY)

refactor(payments): promote compensatory-action closure to method (DRY)

refactor(payments): add GatewayRef dataclass for gateway identity (DRY)

refactor(payments): use self.state.response consistently; drop dup TYPE_CHECKING import

docs: drop mandate-feature planning docs from the architecture branch

fix(payments): handle PSL lock contention in process_response

fix(payments): surface unmapped status as handled error in _process_response

fix(payments): read HTTPError body from exception in proceed

fix(payments): align PSL status schema default with code state

fix(payments): resolve PSL controller uncached to avoid state bleed

fix(payments): validate TxData when merging updates into PSL

fix(payments): purge all terminal PSL logs, not just Paid

fix(payments): resolve controller via get_doc in initiate() too

fix(payments): stop leaking gateway secrets into guest /pay templates

fix(payments): escape user-influenced vars in /pay (stored XSS)

fix(payments): minimize payer PII persisted in Payment Session Log

fix(payments): return opaque correlation code, not Error Log name, to guests

fix(payments): restrict guest select_button to POST (CSRF hardening)

fix(security): complete M4 on the button-not-found path in select_button

refactor(payments): extract _invoke_ref_doc_hook from _process_response

refactor(payments): dedup PSL initiation setters via _set_initiation_state

refactor(payments): PSLName/PaymentUrl str subclasses -> TypeAlias

refactor(payments): validate controller invariants in __init_subclass__

fix(types): correct TxData.loyalty_points annotation (tuple, not list[str, float])

docs(payments): note __init_subclass__ definition-time behavior re abstract intermediates