Skip to content
This repository was archived by the owner on Dec 6, 2021. It is now read-only.

docs: Redisearch Installation - #145

Closed
NagariaHussain wants to merge 3 commits into
frappe:masterfrom
NagariaHussain:docs-redisearch
Closed

docs: Redisearch Installation #145
NagariaHussain wants to merge 3 commits into
frappe:masterfrom
NagariaHussain:docs-redisearch

Conversation

@NagariaHussain

Copy link
Copy Markdown
Member

Updated documentation for Redis 6 and Redisearch module.

@NagariaHussain
NagariaHussain marked this pull request as ready for review June 2, 2021 10:44
@NagariaHussain NagariaHussain changed the title docs(WIP): Docs redisearch docs: Docs redisearch Jun 2, 2021
@NagariaHussain NagariaHussain changed the title docs: Docs redisearch docs: Redisearch Installation Jun 3, 2021
Python 3.6+
Node.js 12
Redis 5 (caching and realtime updates)
Redis 6 (caching and realtime updates)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System requirements vary depending on Frappe versions. That should be made evident here. Specify that Version 13 requires Redis 6. But then we have develop which has higher Node requirements too....

This should be tracked on it's own separate page.

Is there a corresponding Frappe PR for this? Or do the older client versions simply work?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works without any changes on v13.


Congratulations, you have installed bench on to your system.

## [ERPNext] Optional: Redisearch Redis Module

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here. We can't keep adding a list of app-specific dependencies in Frappe. Add this section as a system dependency in the ERPNext docs instead.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move this to ERPNext docs. Need to figure out where.

@NagariaHussain

Copy link
Copy Markdown
Member Author

Moved via frappe/erpnext_documentation#375

@NagariaHussain
NagariaHussain deleted the docs-redisearch branch July 23, 2021 10:24
@gavindsouza

Copy link
Copy Markdown
Contributor

Don't we need to upgrade Redis to v6 too? @NagariaHussain

@NagariaHussain

Copy link
Copy Markdown
Member Author

Don't we need to upgrade Redis to v6 too? @NagariaHussain

Yes, it is good we update the version here too. Will create other PR which updates the docs just for Redis 6. On MacOS, its default now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants