fix: do not fetch a random inventory account when multiple inventory accounts exist - #57626
Merged
rohitwaghchaure merged 2 commits intoJul 30, 2026
Conversation
rohitwaghchaure
added
backport version-15-hotfix
backport version-16-hotfix
and removed
stock
needs-tests
rohitwaghchaure
force-pushed
the
fixed-fetch-default-inventory-acc
branch
from
July 30, 2026 11:52
bd40671 to
75eb2dc
Compare
rohitwaghchaure
enabled auto-merge (squash)
July 30, 2026 11:52
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Confidence Score: 5/5The PR appears safe to merge. The previously missing cardinality regression coverage now exercises both the valid single-account fallback and rejection when multiple stock accounts exist, and no blocking failure remains. Reviews (2): Last reviewed commit: "test: set default inventory account inst..." | Re-trigger Greptile |
rohitwaghchaure
added a commit
that referenced
this pull request
Jul 30, 2026
…accounts exist (backport #57626) (#57632) * fix: do not fetch a random inventory account when multiple inventory accounts exist (#57626) (cherry picked from commit 386a4ac) # Conflicts: # erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py * chore: fix conflicts Remove redundant inter-company transaction tests and related setup. --------- Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
rohitwaghchaure
added a commit
that referenced
this pull request
Jul 31, 2026
The conflict resolution kept the pre-backport copy of test_valuation_taxes_lcv_repost_after_billing, which enables perpetual inventory on _Test Company without configuring a default inventory account. The test then failed on submit and leaked the perpetual inventory flag, breaking every stock test that ran after it in the same process. Restore the cherry-picked version from #57626. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rohitwaghchaure
added a commit
that referenced
this pull request
Jul 31, 2026
…accounts exist (backport #57626) (#57631) * fix: do not fetch a random inventory account when multiple inventory accounts exist (#57626) (cherry picked from commit 386a4ac) # Conflicts: # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py * chore: fix conflicts Removed redundant test for valuation taxes in purchase receipt. * fix: build warehouse account map only when perpetual inventory needs it For asset purchase receipts or provisional accounting with perpetual inventory disabled, GL entries do not use warehouse accounts. Building the full warehouse account map in that case now throws when a company has multiple inventory accounts and no default, breaking asset receipt submission. Mirrors the gating on develop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test: set default inventory account in valuation taxes LCV test The conflict resolution kept the pre-backport copy of test_valuation_taxes_lcv_repost_after_billing, which enables perpetual inventory on _Test Company without configuring a default inventory account. The test then failed on submit and leaked the perpetual inventory flag, breaking every stock test that ran after it in the same process. Restore the cherry-picked version from #57626. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.