chore: release v16 - #57610
Closed
frappe-pr-bot wants to merge 9 commits into
Closed
Conversation
refactor: reuse shared date range validation across reports
(cherry picked from commit f328018)
…-57314 fix(italy): skip e-invoicing for opening invoices (backport #57314)
…eck (backport #57592) (#57597) fix: let Purchase Receipt cancel defer to Frappe's linked-document check (#57592) on_cancel pre-blocked cancellation with its own "Purchase Invoice is already submitted" guard, duplicating the check Frappe already runs for any submitted linked document. Drop the guard and the unused check_next_docstatus() method it mirrored so the receipt defers to the framework: the Cancel All Documents flow cancels the invoice first and then the receipt, and a direct cancel is still rejected by Frappe's linked-document check. Add a regression test that a direct cancel of a receipt with a submitted invoice is rejected and rolls back, leaving no stray stock or GL entries. (cherry picked from commit cfe18e8) # Conflicts: # erpnext/stock/doctype/purchase_receipt/purchase_receipt.py # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py Co-authored-by: Jatin3128 <140256508+Jatin3128@users.noreply.github.com>
…ia Update Items (backport #57419) (#57601) Row removal called cancel() and delete() on the child row, and both check permissions against the parent doctype. Dropping a row therefore needed Cancel and Delete on the order, while the rest of the dialog only needs Write: the button is gated on has_perm("write"), update_child_qty_rate checks parent Write, and edits save with ignore_permissions=True. Set ignore_permissions on the row before cancel/delete so removal sits behind the same parent Write check as add and edit. validate_child_on_delete is unchanged, so rows with ordered, received, delivered or billed qty are still refused. On version-16-hotfix validate_and_delete_children still lives in erpnext/controllers/accounts_controller.py, not the extracted erpnext/accounts/services/child_item_update.py module it was moved to on develop. Co-authored-by: Kaushal Shriwas <64089478+kaulith@users.noreply.github.com>
…(backport #57334) (#57513) fix(stock): keep manufactured item rate at zero when inputs are free (#57334) * fix(stock): keep manufactured item rate at zero when inputs are free when a finished item is produced from raw materials consumed at zero valuation, the incoming rate fell back to the item's own valuation rate (or BOM cost), valuing free inputs as output and inflating the fg value on every production run. add has_consumption_basis() to detect when the consumed cost is known even if it is zero (consumed rows present, or a consumption entry exists for the work order). when it is, skip the get_valuation_rate and BOM-cost fallbacks so a real cost of zero is preserved. * test(stock): cover manufacture rate for zero-valued raw materials - manufacture from a free input keeps fg basic_rate and sle incoming_rate/stock_value_difference at zero even when the fg already carries a valuation in the target warehouse - material consumption on with no consumption entry does not fall back to bom/price-list rate for free inputs - zero-valued consumption entry keeps the manufacture entry's fg rate at zero (cherry picked from commit 73224d3) Co-authored-by: Sudharsanan Ashok <135326972+Sudharsanan11@users.noreply.github.com>
frappe-pr-bot
requested review from
mihir-kandoi,
rohitwaghchaure and
ruthra-kumar
as code owners
July 30, 2026 04:59
github-actions
Bot
added
skip-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated weekly release.