Skip to content

fix: Load control & dialog assets with cart.js (backport #29625) #29627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marination merged 2 commits into from
Feb 3, 2022
Merged

fix: Load control & dialog assets with cart.js (backport #29625) #29627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ba073
fix: Load control & dialog assets with cart.js
surajshetty3416 Feb 3, 2022
1662ac9
fix: Remove `cart.js` from erpnext-web bundle
marination Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion erpnext/public/js/erpnext-web.bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import "./website_utils";
import "./wishlist";
import "./shopping_cart";
import "./cart";
import "./customer_reviews";
import "../../e_commerce/product_ui/list";
import "../../e_commerce/product_ui/views";
Expand Down
4 changes: 1 addition & 3 deletions erpnext/public/js/cart.js → erpnext/templates/pages/cart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
// Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
// License: GNU General Public License v3. See license.txt

// js inside blog page

// shopping cart
// JS exclusive to /cart page
frappe.provide("erpnext.e_commerce.shopping_cart");
var shopping_cart = erpnext.e_commerce.shopping_cart;

Expand Down