refactor: E-commerce (port to develop) (backport #27923) - #29615
Closed
mergify[bot] wants to merge 134 commits into
Closed
refactor: E-commerce (port to develop) (backport #27923)#29615mergify[bot] wants to merge 134 commits into
mergify[bot] wants to merge 134 commits into
Conversation
- Created "Website Item" to handle website related information - Publishing Item new flow - Created "E Commerce Settings" - Removed Products Settings (cherry picked from commit 939b0dd) # Conflicts: # erpnext/e_commerce/doctype/e_commerce_settings/e_commerce_settings.py # erpnext/modules.txt # erpnext/portal/doctype/products_settings/test_products_settings.py # erpnext/stock/doctype/item/item.json
- Removed Shopping Cart Settings - Portal fully driven via E Commerce Settings - All Item listing querying will happen via ProductQuery engine only - Product Listing via Website Items - removed redundant code - Moved all website logic from Item to Website Item (cherry picked from commit eef9cf1) # Conflicts: # erpnext/e_commerce/doctype/e_commerce_settings/e_commerce_settings.py # erpnext/shopping_cart/cart.py # erpnext/shopping_cart/doctype/shopping_cart_settings/shopping_cart_settings.py # erpnext/shopping_cart/doctype/shopping_cart_settings/test_shopping_cart_settings.py # erpnext/shopping_cart/product_info.py # erpnext/shopping_cart/utils.py # erpnext/stock/doctype/item/item.py
- Removed old onboarding slide json and `create_onboarding_docs` methods - Removed website sections from Item master - Removed references to item website fields - Shifted Item doctype website methods to Website Item - Removed WebsiteGenerator from Item doctype - Website Items in Homepage Products section - Removed redundant code from item_group.py - Fix: Item field filters won’t appear in website (cherry picked from commit 025574d) # Conflicts: # erpnext/stock/doctype/item/item.json # erpnext/stock/doctype/item_variant_settings/item_variant_settings.py
(cherry picked from commit b38339c)
…ce Settings - Hide Attribute filters if 'Hide Variants' is enabled in E Commerce Settings - Consider 'Hide Variants' in ProductQuery Engine - Added docstrings - Remove `get_e_commerce_settings`, redundant (cherry picked from commit f1ce418) # Conflicts: # erpnext/shopping_cart/filters.py
- Patch to make website item from item - Patch to move Products and Shopping Cart Settings into E Commerce Settings - Patch to move products in Homepage from Item to Website Item - Minor cleanup, replacing/removing references to Item website fields (obsolete) (cherry picked from commit 37a246e) # Conflicts: # erpnext/patches.txt
- Moved all files and web templates from Shopping Cart to E-commerce module - Made Shopping Cart module obsolete - Moved select E-commerce related files from Portal to E-commerce module - Minor cleanups - Fixed Shopping Cart and Product Configurator tests (cherry picked from commit 22f41a1) # Conflicts: # erpnext/e_commerce/shopping_cart/utils.py # erpnext/setup/doctype/item_group/item_group.py # erpnext/stock/doctype/item/item.json
- Added Shop by Category Page - Tabbed sections for item fields in Shop by Category Page - Added Shop by Category Section in E commerce Settings - Nested Navigation & Breadcrumbs in Item group pages - Added scrollable & clickable Sub categories in Item Group page - Made breadcrumbs slightly dynamic in Item Page - Added image to Brand doctype (cherry picked from commit d7130e3)
- Rough UI for card actions - Wishlist doctype - Indicators on card based on stock availability (cherry picked from commit 16b9c8c)
- Increased qty in cart on clicking add to cart for existing item - Simplified macro arguments - Navbar cart icon animation - Explore button for template item in card - Add to cart button animation (cherry picked from commit 4f64d1c)
- Add remove items from wishlist - Wishlist icon at nav bar - Animate wishlist icon in card and navbar - Remember wished state after refresh as well (cherry picked from commit 96cc506)
- Navbar icon with badge count for wishlist - Wishlist page with cards - Cards can be moved to cart or removed in a click - Separated all wishlist related methods into wishlist.js - Made a common js method(util) to add/remove wishlist items - Bug fix: Make sure items are removed from session user's wishlist (cherry picked from commit 5951440)
(cherry picked from commit cd11714)
… Page - Add to Wishlist button next to add to cart - Beautified Product Specifications table section - Product Specifications can be optionally in a tabbed section with custom tabs added - Removed hard coded gray bg to allow custom theme overwrites - Fixed resizing issues in Item Full Page view - Cleaned up inline styles and ported to scss (cherry picked from commit 25ffafa)
- Removed wish-red variable - Removed hover state from remove wishlist item button in card - Removed inline css from wishlist item card (cherry picked from commit 07d7cf0)
- Added Ratings and Reviews section in Item full page view - Added provision to write a review with popup - Created Item Review Doctype to store User-Item unique reviews - Added privision to enable/disable wishlist and reviews in e commerce settings - Hide cart and wishlist actions everywhere (even navbar) depending on settings - Moved some more inline css to scss - Small logic fixes TODO: Reviews full page view with paging (cherry picked from commit b15ff57)
- Created macros for repetitive snippets - Created Customer Reviews full page - View more button to reveal 10 more reviews at a time - Common function to get reviews with start and end (cherry picked from commit c842305)
(cherry picked from commit 3d5f029)
- Registered mrp and price after discounts - slashed price with discount in listing, item page and wishlist - removed redundant imports - renamed method to `get_web_item_qty_in_stock` to get Website Item stock - adjusted styles for resizing - made add to cart button full width on cards (cherry picked from commit 6026185) # Conflicts: # erpnext/utilities/product.py
- Modified date changed due to merge conflict - Changed it to a later date to make sure Item migrates correctly (cherry picked from commit 817f695)
- Discount filters in filters section - Code cleanup (cherry picked from commit 1d94914)
(cherry picked from commit 71f4b98)
(cherry picked from commit 0c47f3a)
(cherry picked from commit e82833f)
(cherry picked from commit 3160187)
- Move indexing logic to separate file - Add more validation logic for 'search index fields' field (cherry picked from commit 8e55c95) # Conflicts: # erpnext/templates/pages/product_search.py
(cherry picked from commit f342155)
(cherry picked from commit ba25460)
(cherry picked from commit ffc8616)
(cherry picked from commit 70b164e)
(cherry picked from commit 5a462db)
…fter selection of one (cherry picked from commit 2623046)
(cherry picked from commit f2fbe90)
(cherry picked from commit 47c8ad0)
- Also, optionally get image from template web item for cart if variant has no image (cherry picked from commit 4f7ec25)
(cherry picked from commit 606f23b)
(cherry picked from commit 143ff71)
(cherry picked from commit 00752ca)
- Remove unused imports - fix test `test_product_list_attribute_filter_builder` (cherry picked from commit 2933cf2) # Conflicts: # erpnext/stock/doctype/item/item.py
(cherry picked from commit 9eeddc2)
- Move `cart.js` to public/js directory - Reorder import sequence in erpnext web bundle - Removed unused script block (cherry picked from commit 8c90c50)
…mgrep to skip (cherry picked from commit 4b62d2d)
- Add cart.js to web bundle - Hide icon conditionally since now this file loads on every single page (cherry picked from commit f47db26)
… notation due to reserved pypika keywords (cherry picked from commit f97642e)
(cherry picked from commit bd3b47f) # Conflicts: # erpnext/patches.txt
The goal of this fix is to not break the patch in case of customizations In this particular case, it's regarding a customized Note DocType with multiple custom mandatory fields (cherry picked from commit 7eb9dc0)
mergify
Bot
requested review from
ankush,
deepeshgarg007,
gavindsouza,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
February 3, 2022 08:51
3 tasks
mergify
Bot
deleted the
mergify/bp/version-14-beta-pre-release/pr-27923
branch
February 3, 2022 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #27923 done by Mergify.
Cherry-pick of 939b0dd has failed:
Cherry-pick of eef9cf1 has failed:
Cherry-pick of 025574d has failed:
Cherry-pick of f1ce418 has failed:
Cherry-pick of 37a246e has failed:
Cherry-pick of 22f41a1 has failed:
Cherry-pick of 6026185 has failed:
Cherry-pick of 817f695 has failed:
Cherry-pick of 8e55c95 has failed:
Cherry-pick of 41a5ebc has failed:
Cherry-pick of aca3c8f has failed:
Cherry-pick of 16abfd4 has failed:
Cherry-pick of 6432219 has failed:
Cherry-pick of 3fd929c has failed:
Cherry-pick of 335a237 has failed:
Cherry-pick of dc42c45 has failed:
Cherry-pick of 9fb61ef has failed:
Cherry-pick of 456f277 has failed:
Cherry-pick of 2933cf2 has failed:
Cherry-pick of bd3b47f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com