Skip to content

feat: Item Tax Templates for Germany - #25858

Merged
deepeshgarg007 merged 11 commits into
frappe:version-13-hotfixfrom
alyf-de:item-tax-templates
Jun 9, 2021
Merged

feat: Item Tax Templates for Germany#25858
deepeshgarg007 merged 11 commits into
frappe:version-13-hotfixfrom
alyf-de:item-tax-templates

Conversation

@barredterra

@barredterra barredterra commented May 27, 2021

Copy link
Copy Markdown
Collaborator
  • Item Tax Templates for Germany

    Before:

    • One Sales Taxes and Charges Templates for each VAT rate: "VAT 19%", "VAT 7%", etc..
    • There were no Item Tax Templates and it would be useless to create them in this structure.
    • You could only select one template, and therefore tax rate, per transaction.
    • Tax Category could only be assigned to only one of the templates, despite all belonging to the same category.

    After:

    • One generic Sales Taxes and Charges Template "VAT" with multiple Accounts at a default rate of 0.00.
    • Item Tax Templates for each tax rate are used to apply the correct rate. This way, Items with different tax rates can be sold in a single transaction.
  • Validate that the provided Company exists before running taxes setup

  • Create Tax Category during taxes setup

    If tax_category is specified in country_wise_tax.json, make sure the Tax Category exists before creating a Tax Template.

  • port to develop.

no-docs

@barredterra
barredterra requested a review from nabinhait May 27, 2021 12:42
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 61.198% when pulling 5079440 on alyf-de:item-tax-templates into 04dfaf3 on frappe:version-13-hotfix.

@deepeshgarg007 deepeshgarg007 self-assigned this May 29, 2021
@deepeshgarg007

Copy link
Copy Markdown
Member

@barredterra Have done something similar for India in this PR #25415

I am creating Tax Categories separately as there are a few custom fields for India and then assigning them to templates.
Any thoughts on this?

@barredterra

Copy link
Copy Markdown
Collaborator Author

@deepeshgarg007 I refactored the Tax Category setup similar to your PR: f259bf4. I think this should also work for your use case.

Comment thread erpnext/setup/setup_wizard/data/country_wise_tax.json Outdated
@barredterra

Copy link
Copy Markdown
Collaborator Author

@deepeshgarg007 could you review this PR first, then rebase yours?

@deepeshgarg007

Copy link
Copy Markdown
Member

@barredterra this looks fine, hence merging this. Will rebase mine

@deepeshgarg007
deepeshgarg007 merged commit 9a282aa into frappe:version-13-hotfix Jun 9, 2021
@barredterra
barredterra deleted the item-tax-templates branch June 9, 2021 07:31
@barredterra
barredterra restored the item-tax-templates branch June 18, 2021 13:46
@barredterra
barredterra deleted the item-tax-templates branch June 18, 2021 16:01
@frappe frappe locked as resolved and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants