feat: Item Tax Templates for Germany - #25858
Merged
deepeshgarg007 merged 11 commits intoJun 9, 2021
Merged
Conversation
Member
|
@barredterra Have done something similar for India in this PR #25415 I am creating Tax Categories separately as there are a few custom fields for India and then assigning them to templates. |
Collaborator
Author
|
@deepeshgarg007 I refactored the Tax Category setup similar to your PR: f259bf4. I think this should also work for your use case. |
barredterra
commented
Jun 2, 2021
Collaborator
Author
|
@deepeshgarg007 could you review this PR first, then rebase yours? |
Member
|
@barredterra this looks fine, hence merging this. Will rebase mine |
deepeshgarg007
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item Tax Templates for Germany
Before:
After:
Validate that the provided Company exists before running taxes setup
Create Tax Category during taxes setup
If
tax_categoryis specified incountry_wise_tax.json, make sure the Tax Category exists before creating a Tax Template.port to
develop.