add except + to bkz_reduction and hkz_reduction#315
Merged
Conversation
Collaborator
|
Ta! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
the two
bkz_reductionoverloads infplll.pxdare declared withoutexcept +. Cython therefore does not wrap calls to them in a C++ try/catch. when fplll's C++ core throws, the exception crosses the Cython boundary uncaught, triggeringstd::terminate()→abort()→SIGABRTon Python 3.12 and Python 3.13 this escalates to a fatal SIGSEGV due to a separate ABI incompatibility in cysignals (the signal handler tries to build a Python traceback, but no Python exception has been set → NULL pointer dereference)
with this change, Cython generates a try/catch around the C++ call. the C++ exception is converted to a clean Python
RuntimeErrornote that
svp_reductionin the same file already hasexcept +how to reproduce
output:
note
the SIGSEGV does not reproduce on Python 3.14, but this is coincidental, the fpylll 0.6.4 cp314 wheel happened to be compiled against cysignals 1.12.6 headers (because 1.12.6 was the first cysignals version to support Python 3.14). fplll's C++ exception still reaches
std::terminate(), it just doesn't escalate to a SIGSEGV