fix(chat): inline Mighty Deed lookup + enhanced-card formatting (#786)#787
Merged
Conversation
The enhanced attack card's crit-result and Mighty Deed prompt rows read
poorly in a narrow chat sidebar:
- The crit line showed a redundant double label ("Critical!" prompt +
"Crit Result") and, when it wrapped, stranded the parentheses across
lines ("… 3 (" / ") …"). Drop the redundant "Critical!" prompt and
wrap "(<crit table link>)" in a nowrap span so the parens stay glued
to the table pill and wrap as one unit.
- Center the damage/crit/fumble inline-result lines (previously only
centered in compact mode) and the deed prompt so they line up with the
card's otherwise-centered body instead of hugging the left margin.
Verified before/after against the real compiled CSS + Foundry core pill
styles at sidebar widths (185-300px).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…786) The deed die is rolled as part of the attack, so picking a Mighty Deed table is a lookup of the existing result, not a new roll: - Replace the "Roll Deed" button with a "Choose Deed" table picker (nothing preselected). Picking a table looks the deed die result up and renders it inline beneath the picker — no new roll, no separate chat message. The choice persists on the message (author/GM-editable) so it is shared with other viewers and survives the card re-rendering. - Only the table picker is offered, and only on a successful deed (the data layer already gates deedTables on deedDieRollResult > 2). - Add DCC.MightyDeedChooseTable across all seven languages. - Drop the weapon damage-formula tag from the enhanced-card footer; it duplicated the already-shown deed die and read as clutter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- mighty-deeds.spec.js: assert the new deed UX — no "Roll Deed" button, a "Choose Deed" placeholder with nothing preselected, the looked-up result rendered inline on the same card (no new chat message), the persisted dcc.deedSelectedTable flag, and that the pick + result survive a re-render. Drop the old button-click / separate-message assertions. - adapter-dispatch.spec.js: rename the leftover "NPC Skill InheritDie" fixture to the "P1 " prefix so the describe's beforeEach/afterEach actor sweep deletes it (it had been accumulating in the world every run). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The dcc-core-lib adapter refactor landed on main, so its working docs are obsolete: - Delete the 7-phase plan (ARCHITECTURE_REIMAGINED.md), the progress / session-start / slice-backlog scaffolding, the per-phase progress logs, the CLASS_DECOMPOSITION and SCHEMA_SLIMMING design records, and the two landed-fix notes. - Scrub the resulting broken doc-to-doc links and neutralize stale refactor-branch mentions in the surviving guides (EXTENSION_API, PROGRAMMATIC_ACTOR_CREATION, TESTING, PRERELEASE_PROCESS, README), and fix a now-false claim in PRERELEASE_PROCESS (the vendor dir ships on main now, so any build includes it). - CLAUDE.md: drop the obsolete refactor-slice standing authorization and the Refactor-slice testing-requirements section; add a general "update tests (unit + E2E) with the code, every branch" rule; remove the deleted docs from the doc index. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cyface
added a commit
that referenced
this pull request
Jun 26, 2026
Follow-up to removing the dcc-core-lib refactor docs (#787): reword the comments that pointed at the deleted docs (ARCHITECTURE_REIMAGINED, 00-progress, CLASS_DECOMPOSITION, SCHEMA_SLIMMING, SPELL_CHECK_LABEL_ OVERRIDE) so they describe the point inline instead of citing a file that no longer exists. Comment-only; no behavior change. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #786.
Enhanced attack card formatting (#786)
( Crit Table III )glued to the table pill so it never strands across a wrap in a narrow chat sidebar.1d8+d3+1) and read as clutter.Mighty Deed: inline lookup instead of a "Roll Deed" button
The deed die is rolled as part of the attack, so picking a Mighty Deed table is a lookup of the existing result, not a new roll:
dcc.deedSelectedTable, author/GM-editable) so it's shared with other viewers and survives the card re-rendering.DCC.MightyDeedChooseTablekey translated across all 7 languages.Docs
Testing
game.dcc.buildMightyDeedPrompt/attachMightyDeedListenersAPI, so it picks up the new picker transparently.mighty-deedsspecs pass; the broader suite is green exceptenhanced-attack-cardandweapon-range, which fail only because dcc-qol is enabled in the local test world (it suppresses the system enhanced card and overrides range handling).weapon-rangeis code untouched by this PR — confirming the failures are environmental, not regressions; they reproduce onmainwith dcc-qol on.🤖 Generated with Claude Code