🛡️ Sentinel: [security improvement] Add yaml.unsafe_load and yaml.full_load to serialization sinks#50
Conversation
This ensures that the output of these potentially unsafe deserialization functions correctly sheds validation provenance (becomes `UNKNOWN_RAW`) in the taint propagation logic. Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: ENHANCEMENT
💡 Vulnerability: The static analyzer was missing
yaml.unsafe_loadandyaml.full_loadin its_SERIALISATION_SINKSmapping, potentially leading to false negatives when tracking untrusted data flowing into these dangerous deserialization functions.🎯 Impact: Untrusted data flowing into these dangerous functions might not have been correctly marked as
UNKNOWN_RAW, limiting the engine's ability to trace its origin or flag its subsequent use correctly.🔧 Fix: Added
yaml.unsafe_loadandyaml.full_loadto the_SERIALISATION_SINKSfrozenset insrc/wardline/scanner/taint/variable_level.py.✅ Verification: Ran
make testto verify changes and ensure all tests passed. Requested code review, and received#Correct#. Recorded the learning in.jules/sentinel.md.PR created automatically by Jules for task 17995805523521999269 started by @tachyon-beep