Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.0 tag-cut: operator rollback + storage ops + trust statements (PR 3/4) #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
v1.0 tag-cut: operator rollback + storage ops + trust statements (PR 3/4) #15
Changes from all commits
bf764cbFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section states that v1.0 already enforces single-analyzer execution with an
fs2lock on.clarion/clarion.lock, but at this commit the CLI does not includefs2incrates/clarion-cli/Cargo.tomland the analyze path has no lock acquisition (try_lock_exclusive/clarion.lock) logic. Publishing this as current behavior can cause operators to run concurrentclarion analyzeprocesses under a false safety assumption, which risks exactly the run-state races this section warns about.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence states that
clarion servecurrently emits a[TRUST]startup warning for loopback-no-token mode, but at this commit no such banner exists in the HTTP read server code (the only startup trust warning path is the non-loopback unauthenticated warning incrates/clarion-cli/src/http_read.rs). Operators may rely on a warning that never appears and miss an unauthenticated local deployment on shared hosts.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.