Add NEIndexSet based on indexmap::IndexSet - #58
Closed
StefanTerdell wants to merge 8 commits into
Closed
Conversation
Owner
|
Hi, I just released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds NEIndexSet wrapping indexmap::IndexSet feature-gated to its dependency. The implementation is mostly copy-pasted from the existing NESet one.
This PR builds on the schemars PR (#45) and thus includes all of its commits as well.
Like its parent PR I will not be addressing merge conflicts or change requests. Feel free to merge or close it as is, or use it as a starting point for your own implementation.
Either way, thank you for your work!
Closes #50
This PR is a recreation of #57 that was automatically closed when I renamed the branch.