[feat] allow users to set label and total after Bar's initialization#11
Open
ciehanski wants to merge 2 commits into
Open
[feat] allow users to set label and total after Bar's initialization#11ciehanski wants to merge 2 commits into
ciehanski wants to merge 2 commits into
Conversation
Owner
|
Thank you! I will take a look. |
fosskers
requested changes
May 9, 2023
Owner
|
Sorry that the review took so long! Overall it looks good. I think we can improve the naming a bit; the word "total" is a bit confusing (my own fault for the original wording). It's not clear whether it refers to the running total, or the "target total", so I suggested a switch to "target". Thoughts? |
Author
|
Makes sense to me, I completely agree - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Firstly, thank you for a fantastic crate. I appreciate how simple and easy
Linyais compared to many other progress bar crates out there.This PR would add 4 pub set helper functions which would allow the user to modify a specific
Bar's total or label after theBarhas been initialized. I've found this useful in cases where I do not know the total size of the data, but I want the draw the progress bar and then update its total once gathered. In my local tests I was able to accomplish what I was after.If there is a more optimal way to achieve this without the need for this PR, please let me know.
Thanks,
ciehanski