Skip to content

fix(ro-RO): insert "de" before the currency unit for 20+ #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TylerVigario merged 2 commits into from
Jun 16, 2026
Merged

fix(ro-RO): insert "de" before the currency unit for 20+ #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2853ae1
fix(ro-RO): insert "de" before the currency unit for 20+
TylerVigario Jun 16, 2026
583854a
test(ro-RO): pin the "de" boundary at 19/20 and clarify the rule comment
TylerVigario Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ro-RO.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,14 @@ function toCurrency(value) {
}
else {
const leuWord = integerToWords(dollars, 'masculine')
parts.push(leuWord + ' ' + LEU_PLURAL)
// Romanian inserts "de" before the noun for the CLDR `other` category:
// count >= 20 whose last two digits are 00 or 20-99 — "douăzeci de lei",
// "o sută de lei", but "o sută unu lei" (101) and no "de" below 20. The
// bani path below applies the same rule; buildScalePhrase uses a related
// per-segment predicate for scale words.
const m = dollars % 100n
const needsDe = dollars >= 20n && (m === 0n || m >= 20n)
parts.push(leuWord + (needsDe ? ' de ' : ' ') + LEU_PLURAL)
}
}

Expand Down
16 changes: 9 additions & 7 deletions test/fixtures/ro-RO.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,12 @@ export const currency = [
[2, 'doi lei'],
[5, 'cinci lei'],
[10, 'zece lei'],
[21, 'douăzeci și unu lei'],
[42, 'patruzeci și doi lei'],
[100, 'o sută lei'],
[1000, 'o mie lei'],
[19, 'nouăsprezece lei'],
[20, 'douăzeci de lei'],
[21, 'douăzeci și unu de lei'],
[42, 'patruzeci și doi de lei'],
Comment on lines 214 to +218

@TylerVigario TylerVigario Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 583854a — added [20, 'douăzeci de lei'] and also [19, 'nouăsprezece lei'] to pin the >= 20 boundary on both sides, so a > 20 vs >= 20 off-by-one fails either direction.

[100, 'o sută de lei'],
[1000, 'o mie de lei'],

// Bani only
[0.01, 'un ban'],
Expand All @@ -229,12 +231,12 @@ export const currency = [
[1.01, 'un leu un ban'],
[1.50, 'un leu cincizeci de bani'],
[2.02, 'doi lei doi bani'],
[42.50, 'patruzeci și doi lei cincizeci de bani'],
[100.99, 'o sută lei nouăzeci și nouă de bani'],
[42.50, 'patruzeci și doi de lei cincizeci de bani'],
[100.99, 'o sută de lei nouăzeci și nouă de bani'],

// Negative amounts
[-1, 'minus un leu'],
[-42.50, 'minus patruzeci și doi lei cincizeci de bani'],
[-42.50, 'minus patruzeci și doi de lei cincizeci de bani'],

// Edge cases
['5.00', 'cinci lei'],
Expand Down