fix(js): forward all batches in ChannelBatchReader - #38
Open
fornwall wants to merge 1 commit into
Open
Conversation
`ChannelBatchReader::next` built a fresh `StreamReader` for each buffer received from the channel and returned only the first record batch it yielded. When a pushed IPC buffer contained more than one record batch, every batch after the first was silently dropped, causing data loss on bind/insert. Buffer the in-progress `StreamReader` in a new `current` field and drain it fully across successive `next()` calls before pulling the next buffer off the channel. Empty buffers are skipped while genuine decode errors are still surfaced. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XNCrC87g9MkppGpL4MDgh5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (silent data loss)
ChannelBatchReader::nextinjavascript/src/client.rsbuilt a freshStreamReaderfor each IPC buffer received from the channel and returned only the first record batch it yielded. When a pushed IPC buffer contained more than one record batch, every batch after the first was silently dropped, corrupting data on bind/insert.Fix
Buffer the in-progress
StreamReaderin a newcurrentfield and drain it fully across successivenext()calls before pulling the next buffer off the channel:currentand fetch the next buffer.StreamReader::try_neware still surfaced asSome(Err(e)).Verified with
cd javascript && cargo build.🤖 Generated with Claude Code
https://claude.ai/code/session_01XNCrC87g9MkppGpL4MDgh5