Rejuvenate tooling, CI, and tests - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Dependencies
preparescript is nowhuskyand the pre-commit hook drops the deprecated shebang andhusky.shsourcing (per the v9 release notes; the v8 format would break in v10).react,react-dom,@types/react,@types/react-dom), so the suite exercises the newest supported peer. React 18 stays supported and is still tested in CI.typescript^5.9.3,vitest^4.1.10,happy-dom^20.11.1,@vitejs/plugin-react^6.0.5.wsandpostcss/viteadvisories.Deliberately not upgraded
CI
npm install --no-savebefore the test step).actions/checkoutandactions/setup-nodebumped to v7. The only breaking change in checkout v7 (blocking fork checkouts forpull_request_target/workflow_run) does not apply to these workflows.Tests
submittingresetting after a failed submit. 8 tests total, all passing.vitest.config.tsto.mtsto silence the CJS-load warning.README
Version
Backward compatibility verification
useFormspark,FormsparkError, and the exported types are unchanged.dist/output is byte-identical, andmain/module/typings/peerDependencies/enginesare identical.require,import(namespace and named exports match exactly), and an SSR + mocked-fetch smoke test of the hook, against React 19 and React 18.Remaining risks
esbuild0.27.7 (Windows dev-server file read, GHSA-g7r4-m6w7-qqqr). The fix is 0.28.1, outside the^0.27ranges pinned by tsup and vite; forcing an override risks build breakage for a dev-only, Windows-only issue. Will clear when tsup/vite bump.