chore(workbench-ui): remediate Dependabot alerts [EN-1249]#754
Conversation
Bump react-router-dom to ^7.18.0 and upgrade vite 6->8 (rolldown, no esbuild) + @vitejs/plugin-react 4->6. Clears all 9 open Dependabot alerts (react-router, esbuild, postcss). npm audit reports 0 vulns.
WalkthroughThe ChangesConversion Interface Field Rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NumaryBot
left a comment
There was a problem hiding this comment.
✅ Approve — automated review
The dependency and lockfile updates appear consistent, and no discrete regression introduced by the patch was identified.
No findings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 66.83% 66.83%
=======================================
Files 923 923
Lines 43100 43100
=======================================
Hits 28808 28808
Misses 12389 12389
Partials 1903 1903 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NumaryBot
left a comment
There was a problem hiding this comment.
✅ Approve — automated review
The dependency bumps and the Conversion interface update are consistent with the current UI/server JSON usage. I did not find a discrete regression introduced by this patch.
No findings.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/workbench/ui/src/api.ts`:
- Line 142: The frontend interface field target_amount does not match the
backend API response field destinationAmount, causing the value to be undefined
when deserialized. Rename the target_amount field to destination_amount in the
interface definition in api.ts to match the camelCase-to-snake_case conversion
convention used for other fields like sourceAmount mapping to source_amount.
Additionally, verify that the type of destination_amount (currently string)
matches the actual format returned by the backend API, which the schema
indicates should be an integer with bigint format, and adjust the type if
necessary to ensure proper deserialization.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 587752a0-4052-4cc1-8099-a445453334aa
⛔ Files ignored due to path filters (2)
tools/workbench/ui/package-lock.jsonis excluded by!**/package-lock.json,!**/*.jsontools/workbench/ui/package.jsonis excluded by!**/*.json
📒 Files selected for processing (1)
tools/workbench/ui/src/api.ts
NumaryBot
left a comment
There was a problem hiding this comment.
✅ Approve — automated review
The dependency updates and the API type adjustment are consistent with the checked-in lockfile and existing backend/UI usage. I did not find any discrete introduced issue that would break existing behavior.
No findings.
Summary
react-router-dom^7.13.0->^7.18.0(clears 7 react-router alerts)vite^6.0.0->^8.0.0(rolldown bundler dropsesbuild-> clears esbuild high alert; pullspostcss 8.5.15-> clears postcss alert)@vitejs/plugin-react^4.2.0->^6.0.0(vite 8 peer)tools/workbench/ui/)Resolves all 9 open Dependabot alerts.
npm audit=> 0 vulnerabilities.Jira: EN-1249
Test plan
npm installclean,npm audit=> 0 vulnerabilitiesvite buildsucceeds (607 modules),dist/producedesbuild; react-router 7.18.0, postcss 8.5.15go run . workbenchand load http://127.0.0.1:8080/uiNote
npm run buildhas a pre-existingtscerror (App.tsx:1703target_amount) unrelated to this change; no CI builds this UI.