-
Notifications
You must be signed in to change notification settings - Fork 5
feat(portal,console-v3): make container command/args configurable #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2574494
e730f6a
6d4fc31
759505a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -268,6 +268,36 @@ See [profiles](./profiles) for more examples. | |
|
|
||
| ## Migration | ||
|
|
||
| ### From v4.X.X To v5.0.0 | ||
|
|
||
| #### Breaking changes | ||
|
|
||
| The bundled `portal` and `console-v3` subcharts have been bumped to `v4.X` (app `v3.0.0`) | ||
| and now default their container `command` / `args` to the slim production image entrypoint | ||
| (`react-router-serve ./build/server/index.js`) and the migration runner to | ||
| `node dist/migrate.cjs`. Consumers still running the legacy `pnpm`-based images **must** | ||
| override these values to keep the previous behavior: | ||
|
|
||
| ```yaml | ||
| portal: | ||
| command: ["pnpm"] | ||
| args: ["start"] | ||
| config: | ||
| migration: | ||
| command: ["pnpm"] | ||
| args: ["migrate", "up"] | ||
|
|
||
| console-v3: | ||
| command: ["pnpm"] | ||
| args: ["start"] | ||
| config: | ||
| migration: | ||
| command: ["pnpm"] | ||
| args: ["migrate", "up"] | ||
| ``` | ||
|
Comment on lines
+281
to
+297
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update template migration overrides to the real legacy pnpm commands. This snippet currently suggests Suggested patch portal:
command: ["pnpm"]
- args: ["start"]
+ args: ["run", "start:prod"]
config:
migration:
command: ["pnpm"]
- args: ["migrate", "up"]
+ args: ["run", "db:migrate"]
console-v3:
command: ["pnpm"]
- args: ["start"]
+ args: ["run", "start:prod"]
config:
migration:
command: ["pnpm"]
- args: ["migrate", "up"]
+ args: ["run", "db:migrate"]🤖 Prompt for AI Agents |
||
|
|
||
| If you already pin a recent image tag shipping the slim entrypoint, no action is required. | ||
|
|
||
| ### From v3.X.X To v4.0.0 | ||
|
|
||
| #### Breaking changes | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix legacy override example to match actual previous pnpm commands.
The migration snippet uses
pnpm startandpnpm migrate up, but the legacy behavior described in this PR context ispnpm run start:prodandpnpm run db:migrate. Following the current example can fail upgrades for existing pnpm-based images.Suggested patch
📝 Committable suggestion
🤖 Prompt for AI Agents