Skip to content

chore: install helm-schema plugin via nix #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dav-14 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −14
Open

chore: install helm-schema plugin via nix #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,13 @@ lint:
tidy: lint
@cd ./tools/readme && go mod tidy

helm-schema-install:
helm plugin install https://github.com/losisin/helm-values-schema-json.git --version v1.9.2 || true

helm-schema path='':
helm schema -input {{path}}/values.yaml -output {{path}}/values.schema.json
helm schema --values {{path}}/values.yaml --output {{path}}/values.schema.json
Comment on lines 16 to +17

@coderabbitai coderabbitai Bot Apr 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Default path='' can produce invalid absolute paths.

If called without args, Line 17 targets /values.yaml and /values.schema.json. Default to . to keep paths project-relative.

Suggested fix 
-helm-schema path='':
-  helm schema --values {{path}}/values.yaml --output {{path}}/values.schema.json
+helm-schema path='.':
+  helm schema --values {{path}}/values.yaml --output {{path}}/values.schema.json
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
helm-schema path='':
helm schema -input {{path}}/values.yaml -output {{path}}/values.schema.json
helm schema --values {{path}}/values.yaml --output {{path}}/values.schema.json
helm-schema path='.':
helm schema --values {{path}}/values.yaml --output {{path}}/values.schema.json
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@Justfile` around lines 16 - 17, The helm-schema justfile recipe uses a
default path value of '' which yields absolute paths like /values.yaml when
invoked without args; change the default for the parameter named path in the
helm-schema recipe from an empty string to '.' so the template invocations (helm
schema --values {{path}}/values.yaml --output {{path}}/values.schema.json)
resolve to project-relative ./values.yaml and ./values.schema.json instead of
root-level files.


helm-docs:
go run github.com/norwoodj/helm-docs/cmd/helm-docs@v1.14 --chart-search-root=charts --document-dependency-values --skip-version-footer

helm-all package="false" publish='false' packageArgs="": helm-docs helm-schema-install
helm-all package="false" publish='false' packageArgs="": helm-docs
#!/bin/bash
set -euo pipefail

Expand Down
12 changes: 6 additions & 6 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
description = "Wallets dev env";

inputs = {
nixpkgs.url = "https://flakehub.com/f/NixOS/nixpkgs/0.1.*.tar.gz";
nixpkgs.url = "https://flakehub.com/f/NixOS/nixpkgs/0.2511.*.tar.gz";

nur = {
url = "github:nix-community/NUR";
Expand All @@ -12,7 +12,7 @@

outputs = { self, nixpkgs, nur }:
let
goVersion = 23;
goVersion = 26;

supportedSystems = [
"x86_64-linux"
Expand Down Expand Up @@ -49,7 +49,9 @@
ginkgo
pkgs.nur.repos.goreleaser.goreleaser-pro
just
kubernetes-helm
(wrapHelm kubernetes-helm {
plugins = [ kubernetes-helmPlugins.helm-schema ];
})
kustomize_4
mockgen
yq
Expand Down
Loading