feat(payments): EN-123 connector schedules CLI#162
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughAdds CLI commands under payments connectors for schedules and schedule instances: root wiring, list and show commands, API v3 enforcement, cursor-based pagination stores, and table rendering of schedules and instances. ChangesConnector schedules and instances CLI commands
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Expose GET /v3/connectors/{connectorID}/schedules,
GET /v3/connectors/{connectorID}/schedules/{scheduleID}, and
GET /v3/connectors/{connectorID}/schedules/{scheduleID}/instances
under fctl payments connectors schedules. V3-only; wired directly to
existing formance-sdk-go/v3 v3.8.1 (no SDK bump).
- Drop redundant ConnectorID column from `schedules list` (already a required arg) - Drop redundant ScheduleID/ConnectorID columns from `schedules instances list` - Migrate new schedule commands from v3 to v4 SDK (types moved shared -> payments) - Surface PausedAt/PausedReason in `schedules get` detail view Co-authored-by: Cursor <cursoragent@cursor.com>
1586c78 to
13d64c1
Compare
thierrycoopman
left a comment
There was a problem hiding this comment.
@laouji can you re-check?
Summary
fctl payments connectors schedules {list,get}wired to Payments v3 schedule endpointsfctl payments connectors schedules instances listfor schedule instance paginationTest plan
go build ./...andgo vet ./...passgofmt -l .cleanfctl payments connectors--output json